Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed Ecosia Favicon #9291

Merged
merged 1 commit into from
Jun 11, 2017
Merged

Fixed Ecosia Favicon #9291

merged 1 commit into from
Jun 11, 2017

Conversation

newm-newm
Copy link
Contributor

@newm-newm newm-newm commented Jun 6, 2017

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Favicon does not display correctly when pulling the favicon information from Brave source. Such as when searching using engine go key or in preferences page. Already worked when navigating on ecosia domain.

fixed by updating the favicon URL from Ecosia. For some reason www.domain.com/favicon.ico did not work originally.

Copy link

@cndouglas cndouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me.

@bsclifton
Copy link
Member

Thanks for the fix! 😄 👍

@bsclifton bsclifton merged commit cafc9cb into brave:master Jun 11, 2017
bsclifton added a commit that referenced this pull request Jun 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants